[FIX] canvas/preview: Fix workflow preview rendering #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplement QSvgGenerator.metric to account for QTBUG-63159
astaric
approved these changes
Sep 13, 2017
| @@ -902,6 +902,17 @@ def font_from_dict(font_dict, font=None): | |||
| return font | |||
|
|
|||
|
|
|||
| if QT_VERSION >= 0x50900 and \ | |||
There was a problem hiding this comment.
Should this be pulled to the top of the file (after imports?)
There was a problem hiding this comment.
I would prefer to keep it near grab_svgwhere it is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Most widget icons are not displayed in the workflow preview due to QTBUG-63159
Description of changes
Reimplement QSvgGenerator.metric to report proper device pixel ratio.
Includes